[codex] add Horizon 5.0R resistance table - #4759
Merged
Merged
Conversation
cagnulein
force-pushed
the
codex/horizon-5r-resistance-table
branch
from
June 26, 2026 18:57
a0b243c to
949e092
Compare
cagnulein
force-pushed
the
codex/horizon-5r-resistance-table
branch
from
June 27, 2026 03:25
949e092 to
8666183
Compare
Quantize cadence to 5 RPM bands in resistanceFromPowerRequest before the table lookup. Without this, a 2 RPM cadence change shifts the interpolated wattage estimate enough to cross a resistance boundary, triggering unnecessary resistance changes on bikes with high-density ERG tables (e.g. user-learned data at 1 RPM granularity). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cagnulein
marked this pull request as ready for review
July 1, 2026 15:08
Cadence noise right at a lookup-table quantization boundary can flip the computed resistance back and forth every update() cycle even after 5 RPM quantization (04a4501). Require the new resistance to be requested consistently for 2s before committing it, instead of acting on every single fluctuation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResistanceTable20260626.xlsxfor the Horizon 5.0R Bluetooth nameJFBK5.0R.JFBK5.0*devices instead of adding a second Bluetooth pattern.JFBK5.0Rname.Notes
JFBK5.0Rwas already covered by the existingJFBK5.0FTMS bike pattern inbluetooth.cpp. The model-specific change is therefore inftmsbike.cpp, where only the fullJFBK5.0Rname loads the Horizon 5.0R calibration table.Validation
JFBK5.0pattern coverage withrg.git diff --checkg++ -fsyntax-onlycheck for the newhorizon5r_defaults.hheader.Full local build/tests were not completed because this worktree is missing existing dependencies/submodules:
tst/googletestfor tests andsmtpclient/src/SmtpMimefor the app build.